Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub M1 runners #1206

Closed
wants to merge 1 commit into from
Closed

Use GitHub M1 runners #1206

wants to merge 1 commit into from

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Oct 3, 2023

To build and test conda and wheel for release.

@huydhn huydhn requested a review from atalman October 3, 2023 22:34
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 3, 2023
@huydhn huydhn changed the base branch from release/0.7 to main October 3, 2023 22:47
@atalman
Copy link
Contributor

atalman commented Oct 4, 2023

The workflow passes but it does not looks like it builds correct wheel. We are looking for something like this:

torchdata-0.7.0-cp311-cp311-macosx_11_0_arm64.whl 

We probably should just migrate to Nova pipeline for torchdata.

@huydhn
Copy link
Contributor Author

huydhn commented Mar 25, 2024

Closing this as this is outdate. The build workflow in data has been cleaned up, and the label is call macos-m1-stable now.

@huydhn huydhn closed this Mar 25, 2024
@andrewkho andrewkho deleted the switch-macos-m1 branch September 26, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants